Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Create Changelog Action #112

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Fix Create Changelog Action #112

merged 1 commit into from
Aug 18, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Aug 18, 2021

Fix handling of since parameter for the draft_changelog action, which has been causing failing builds in jupyterlab.

@blink1073 blink1073 added the bug Something isn't working label Aug 18, 2021
@blink1073 blink1073 added this to the 0.4 milestone Aug 18, 2021
blink1073
blink1073 approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021 •
edited
Loading

Codecov Report

Merging #112 (625b969) into master (1b16d79) will decrease coverage by 0.50%.
The diff coverage is 7.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   86.18%   85.67%   -0.51%     
==========================================
  Files          17       17              
  Lines        2055     2067      +12     
  Branches      244      246       +2     
==========================================
  Hits         1771     1771              
- Misses        195      207      +12     
  Partials       89       89
Impacted Files Coverage Δ
jupyter_releaser/actions/draft_changelog.py 0.00% <0.00%> (ø)
jupyter_releaser/actions/draft_release.py 0.00% <ø> (ø)
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3127bd9...625b969. Read the comment docs.

@blink1073 blink1073 merged commit cb86e29 into jupyter-server:master Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@afshin @codecov-commenter @blink1073